Skip to content

Conversation

@KKould
Copy link
Member

@KKould KKould commented Dec 20, 2024

What problem does this PR solve?

  • supplement decimal’s memcomparable encode
  • todo code returns error

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould added enhancement New feature or request invalid This doesn't seem right labels Dec 20, 2024
@KKould KKould force-pushed the chore/decimal_mem_comparable branch from 6255acb to 566d164 Compare December 20, 2024 17:57
@KKould KKould merged commit a7b3d5f into main Dec 20, 2024
6 checks passed
@KKould KKould deleted the chore/decimal_mem_comparable branch July 21, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants